AI Agents SDE Task Viewer
      • Pr description
  1. Home
  2. AgentSDE
  3. agent-core
  4. gh-228
  5. changes
  6. pr_description.md
pr_description.md(1.9 KB)· Apr 1, 2026· 2 min read
  • Title
  • Problem
  • Task / Link
  • Changes
  • Notes
  • Quality Checks
  • Testing

Title#

Add pre-PR quality gate and /agent skip-quality-gate directive

Problem#

Agent-created PRs lacked automated quality checks before opening, risking lint failures, test regressions, or merge conflicts landing in review. There was also no way to bypass checks for known-good emergency changes.

Task / Link#

Closes #228

Changes#

  • Add skip-quality-gate to ALLOWED_DIRECTIVES and VALID_DIRECTIVES; directive sets a one-time override flag on the task and posts a confirmation comment without re-dispatching
  • Add qualityGateOverride boolean column (default false) to TaskEntity
  • Add setQualityGateOverride method to TaskStateService
  • Pass QUALITY_GATE_OVERRIDE=1 env var to the deliver phase invocation when override is set; reset flag atomically before phase starts (one-time use)
  • Create scripts/tools/pre-pr-gate.sh — runs lint, tests, and merge conflict check; emits a structured markdown table; accepts --skip for override mode; exits non-zero on failure

Notes#

  • .claude/skills/deliver-implementation/SKILL.md and .claude/skills/implement-code/pr-description-standard.md are planned changes (integrate pre-pr-gate.sh into deliver flow, add Quality Checks section to PR description standard) but were blocked by the permissions system during this run. Those skill files require a follow-up edit with appropriate permissions.
  • The qualityGateOverride column uses a SQLite default (false), so existing in-flight tasks are unaffected without a migration.

Quality Checks#

CheckStatus
Lint✅ passed
Tests✅ passed (638 total)
Merge conflicts✅ none

Testing#

  • npm run lint — 0 errors (4 pre-existing warnings in unrelated file)
  • npm run test — all 638 tests pass including 3 new quality gate override tests in phase-router.service.spec.ts and 2 new tests in directive.service.spec.ts
PrdAgent-runner