AI Agents SDE Task Viewer
      • Pr description
  1. Home
  2. AgentSDE
  3. agent-core
  4. gh-358
  5. changes
  6. pr_description.md
pr_description.md(1.6 KB)· Apr 9, 2026· 1 min read
  • Title
  • Problem
  • Task / Link
  • Changes
  • Notes
  • Testing

Title#

fix: fix test regressions from #342 pipeline refactor and multi-tenant branch

Problem#

After the #342 pipeline refactor, several E2E tests and unit tests were broken. quality-gate.e2e-spec.ts still asserted old gating behavior; multiple test modules lacked required provider mocks; and watchdog.service.spec.ts had duplicate let declarations causing a parse failure in the entire watchdog test suite.

Task / Link#

Closes #358

Changes#

  • src/watchdog/watchdog.service.spec.ts — remove duplicate let originalStuck/let originalSlow declarations and duplicate beforeAll/afterAll blocks (caused SyntaxError parse failure for the entire watchdog test suite)
  • test/quality-gate.e2e-spec.ts — update 4 scenarios to reflect #342 behaviour: phase_review now invokes the review skill directly instead of gating
  • test/event-service.e2e-spec.ts — add EventEmitter2 mock to test module providers
  • test/task-state.e2e-spec.ts — add EventEmitter2 mock to test module providers
  • test/operational.e2e-spec.ts — add EventService, WatchdogService, and EventEmitter2 mocks for OperationalController test module
  • src/llm/claude/claude-cli.provider.ts — lint auto-fix: reformat destructuring for line length

Notes#

  • The watchdog fix was also pushed to rc/multi-tenant to keep the RC branch green
  • E2E full-suite workflow triggered: https://github.com/AgentSDE/agent-core/actions/runs/24164678945
  • rc/multi-tenant is 7 commits ahead of master with multi-tenant scaffolding PRs (#345–#353) merged

Testing#

  • npm run lint — passed, 0 warnings
  • npm run test — 763/763 unit tests pass (including all watchdog tests)
PrdAgent-runner