BJ-0: Add 'jira' to platform unions + audit 'github' hardcodes#
Summary#
Add 'jira' to the two platform union types and verify — via grep — that no platform === 'github' equality branches exist in src/dispatch/, src/phase-router/, src/tenant/, or src/invoke/. This unblocks Wave 1 of the Atlassian integration epic.
Files#
| Path | Action | Description |
|---|---|---|
src/webhook/dto/dispatch-event.dto.ts | modify | Add 'jira' to the platform union (2 occurrences: DispatchEventParams.platform and DispatchEvent.platform) |
src/tenant/tenant-config.interface.ts | modify | Add 'jira' to TenantConfig.platform union |
Steps#
- Extend the
platformunion indispatch-event.dto.ts:19anddispatch-event.dto.ts:37to'github' | 'bitbucket' | 'gitlab' | 'jira'. - Extend the
platformunion intenant-config.interface.ts:9to'github' | 'gitlab' | 'bitbucket' | 'jira'. - Run
npx tsc --noEmitand confirm zero errors. - Run
npm run testand confirm all unit tests pass unchanged. - Capture grep report (commands + output) proving no
platform === 'github'equality checks exist in the four audited paths — include verbatim in PR body.
Verification#
npx tsc --noEmit→ 0 errors after the union changes.npm run test→ all suites green, no snapshot drift.- PR body contains the grep transcript for all four paths showing no matches.
Risks#
- Target branch is
rc/atlassian-integrationper the issue; current worktree sits onrc/multi-tenant. Delivery agent must rebase/target the correct branch before opening the PR.
Assumptions#
- The pre-existing
'github'literals intenant-config.service.ts:20(default config value) andtenant.module.ts:10(default providername) are configuration values, not equality branches, so they are out of scope for the audit.